fix(module-federation): collect secondary entry points from exports #26878 #27999
+256
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Some packages that use
exports
in the package.json may point to a directory such asesm/<entrypoint>
.They would still be imported such as
mypackage/secondary-point
.This needs to be shared still for Module Federation.
However, our current logic for finding secondary entry points for packages looks at the sub dirs of the package and tries to match it with the exports fiels.
Therefore if
mypackage/secondary-point
was set up such thatthen it would never be found correctly, causing share problems.
Expected Behavior
exports of secondary entrypoints should be shared correctly
Related Issue(s)
Fixes #26878