feat(webpack): use sass-embedded and modern-compiler for sass #29999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
FrozenPandaz,
jaysoo and
AgentEnder
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 5bf3f49.
☁️ Nx Cloud last updated this comment at |
Coly010
force-pushed
the
sass-embedded
branch
2 times, most recently
from
da5a1a0 to
a10ea90
Compare
Coly010
force-pushed
the
sass-embedded
branch
from
a10ea90 to
0175a23
Compare
Coly010
force-pushed
the
sass-embedded
branch
from
0175a23 to
89b9ba4
Compare
Coly010
force-pushed
the
sass-embedded
branch
from
89b9ba4 to
ff0ad35
Compare
Coly010
force-pushed
the
sass-embedded
branch
from
ff0ad35 to
32ba3e4
Compare
Coly010
force-pushed
the
sass-embedded
branch
from
32ba3e4 to
622176b
Compare
Coly010
force-pushed
the
sass-embedded
branch
from
622176b to
5bf3f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Webpack and Rspack currently use
sassand its Legacy API withsass-loader.There is also no method to pass stylePreprocessorOptions other than
includePathsto the loaders.Expected Behavior
Switch to using
modern-compilerapi to remove deprecation warnings and improve build performance.Allow users to choose between
sassandsass-embeddedfor sass compiler implementation.Expand the
stylePreprocesserOptionsinterface to acceptincludePaths,sassOptionsandlessOptionsthat will be passed to the appropriate loader.