Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): use uuid when generating tmp tsconfig #30118

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 20, 2025

Current Behavior

When multiple processes/tasks are running in parallel for a single project that produce tmp tsconfig files for buildable libraries, they can clobber each other.

Expected Behavior

Ensure the config file is generated with a unique id to prevent clobbering

@Coly010 Coly010 requested a review from a team as a code owner February 20, 2025 10:04
@Coly010 Coly010 requested a review from leosvelperez February 20, 2025 10:04
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 11:24am

@Coly010 Coly010 self-assigned this Feb 20, 2025
Copy link

nx-cloud bot commented Feb 20, 2025

View your CI Pipeline Execution ↗ for commit 2293fff.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 28m 26s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 32s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-20 11:56:12 UTC

@Coly010 Coly010 force-pushed the js/use-uuid-when-generating-tmp-tsconfig branch from 6141b58 to 2293fff Compare February 20, 2025 11:22
@jaysoo jaysoo merged commit 46e5dce into master Feb 20, 2025
12 checks passed
@jaysoo jaysoo deleted the js/use-uuid-when-generating-tmp-tsconfig branch February 20, 2025 20:53
FrozenPandaz pushed a commit that referenced this pull request Feb 20, 2025
## Current Behavior
When multiple processes/tasks are running in parallel for a single
project that produce tmp tsconfig files for buildable libraries, they
can clobber each other.

## Expected Behavior
Ensure the config file is generated with a unique id to prevent
clobbering

(cherry picked from commit 46e5dce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants