-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repo): replace explicit matrix with dynamic parsed from json #30120
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit e2bd4ea.
☁️ Nx Cloud last updated this comment at |
0c508cc
to
13bf1a9
Compare
@@ -0,0 +1,41 @@ | |||
{ | |||
"coreProjects": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does jq
allow for comments in JSON? Can we annotate what these things mean?
Actually, can we skip jq
and just parse it out in JS instead? And can we also have that as a ts
file that we run via like tsx prepare-matrix.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jq
does not support jsonc
format.
We can load and parse it within script, yes.
We can wrap entire logic within prepare-matrix.ts
and execute it to retrieve matrix JSON. I wanted to avoid ts files to make things "closer to the metal" but I guess there is benefit on wrapping the entire logic away.
This PR replaces the cumbersome explicit matrix in
e2e-matrix.yml
with a dynamic matrix built from the input JSON data.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #