Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): replace explicit matrix with dynamic parsed from json #30120

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Feb 20, 2025

This PR replaces the cumbersome explicit matrix in e2e-matrix.yml with a dynamic matrix built from the input JSON data.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Feb 20, 2025
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 20, 2025 2:02pm

Copy link

nx-cloud bot commented Feb 20, 2025

View your CI Pipeline Execution ↗ for commit e2bd4ea.

Command Status Duration Result
nx run-many -t check-imports check-commit check... ✅ Succeeded 13s View ↗
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded <1s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-20 13:56:42 UTC

@meeroslav meeroslav marked this pull request as ready for review February 20, 2025 11:48
@meeroslav meeroslav requested a review from a team as a code owner February 20, 2025 11:48
@meeroslav meeroslav requested a review from Cammisuli February 20, 2025 11:48
@meeroslav meeroslav marked this pull request as draft February 20, 2025 11:51
@meeroslav meeroslav changed the title feat(repo): combine two nightly templates and add rspack feat(repo): replace explicit matrix with dynamic parsed from json Feb 20, 2025
@meeroslav meeroslav force-pushed the feat/automate-matrix branch from 0c508cc to 13bf1a9 Compare February 20, 2025 12:05
@meeroslav meeroslav marked this pull request as ready for review February 20, 2025 13:26
@@ -0,0 +1,41 @@
{
"coreProjects": [
Copy link
Collaborator

@FrozenPandaz FrozenPandaz Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does jq allow for comments in JSON? Can we annotate what these things mean?

Actually, can we skip jq and just parse it out in JS instead? And can we also have that as a ts file that we run via like tsx prepare-matrix.ts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jq does not support jsonc format.
We can load and parse it within script, yes.

We can wrap entire logic within prepare-matrix.ts and execute it to retrieve matrix JSON. I wanted to avoid ts files to make things "closer to the metal" but I guess there is benefit on wrapping the entire logic away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants