Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rspack): use ts-checker-rspack-plugin instead of fork-ts-checker-webpack-plugin #30121

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 20, 2025

Current Behavior

Our Rspack support currently leverages fork-ts-checker-webpack-plugin to handle typechecking during build.

Expected Behavior

Switch to using ts-checker-rspack-plugin for better memory management and typecheck support.

@Coly010 Coly010 requested a review from a team as a code owner February 20, 2025 11:32
@Coly010 Coly010 self-assigned this Feb 20, 2025
@Coly010 Coly010 requested a review from a team as a code owner February 20, 2025 11:32
@Coly010 Coly010 requested a review from FrozenPandaz February 20, 2025 11:32
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 11:35am

Copy link

nx-cloud bot commented Feb 20, 2025

View your CI Pipeline Execution ↗ for commit a71d613.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 21m 14s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 14s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 38s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-20 11:59:09 UTC

@jaysoo jaysoo merged commit 251959c into master Feb 20, 2025
12 checks passed
@jaysoo jaysoo deleted the rspack/use-rspack-tschecker branch February 20, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants