feat(core)!: drop support for create nodes v1 in favor of only calling create nodes v2 #30616
+2,061
−910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Summary An RFC about this feature is happening here: #29025. This has the most information about this feature. ## Current Behavior <!-- This is the behavior we have today --> Nx currently does not explicitly handle tasks which run continuously until they are terminated. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> This PR adds the initial support for continuous tasks which run continuously until they are terminated. This adds the ability to depend on continuous tasks. There is some more work to be done but this will be enough as an MVP. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
## Current Behavior When `serve, dev, start` targets are inferred by the `@nx/remix` plugin, they are not inferring `continuous`. ## Expected Behavior When `NX_CONTINUOUS_TASKS_PREVIEW` env var exists, infer the `continuous` property.
## Current Behavior The `@nx/js` plugin exposes a helper to generate `build-deps` and `watch-deps` tasks for inference plugins. It does not currently infer `continuous` for the `watch-deps` task. ## Expected Behavior Ensure `watch-deps` is infered with `continuous: true`
## Current Behavior Rspack and Rsbuild Inference Plugins do not infer `continuous` for serve tasks. ## Expected Behavior Correctly infer `continuous` true.
## Current Behavior Webpack Inference Plugin does not currently infer `continuous` for `serve, preview, serve-static` targets. ## Expected Behavior Webpack Inference Plugin correctly infers `continuous: true`
## Current Behavior The `dev`, `serve`, `preview` and `serve-static` targets inferred by the `@nx/vite/plugin` do not infer `continuous:true` indicating to Nx that these tasks are continuous. ## Expected Behavior Infer `continuous: true` for the serve-like targets for Vite.
…-static (#30069) ## Current Behavior The `@nx/storybook/plugin` does not set `continuous:true` for serve-like targets. ## Expected Behavior The plugin should correctly set `continuous: true` for `serve` and `serve-static`.
## Current Behavior Node applications rely on the `@nx/js:node` executor to handle serving. Unfortunately, it can not be determined if existing usage of the executor is used for a continuous or finite task. ## Expected Behavior Generate new node applications with `continuous: true` for their serve targets
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Unit tests are broken after rebase ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Unit tests are passing ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
BREAKING CHANGE: Removes support for v1 of the create nodes API. Plugins need to migrate to createNodesV2 for nx 21 support
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 19ebfb3.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
force-pushed
the
next-major
branch
9 times, most recently
from
9a4c671 to
cf7cc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Plugins will need to migrate to create nodes v2 if they haven't already to stay supported.
Current Behavior
Currently if a plugin exports only
createNodes, we adapt it to acreateNodesV2under the hood and run it. If a plugin exports both, we only run the v2 api.Future Behavior
In the future we want
createNodesV2to becomecreateNodes. To facilitate this transition for the duration of Nx 21,createNodeswill not be invoked. This gives plugin authors time to migrate over to the v2 spec and export it fromcreateNodessuch that it will be ready to be called in the future.