Skip to content

[#41]: Streamline signing for CoRIM protected header + test both routes#43

Merged
iadgovuser26 merged 3 commits into
mainfrom
issue_41
May 7, 2026
Merged

[#41]: Streamline signing for CoRIM protected header + test both routes#43
iadgovuser26 merged 3 commits into
mainfrom
issue_41

Conversation

@iadgovuser62

@iadgovuser62 iadgovuser62 commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

There are 2 typical routes of actions for RIMs in this tool:

  1. Create (unsigned) > Sign > Verify
  2. Create (signed) > Verify

Currently for CoRIM, these 2 routes differ greatly and the codeflow is different for Create (unsigned) versus Create (signed). Specifically, the Create (signed) code adds fields to the protected header (i.e. corim-meta-map) which the current IETF spec requires (see section 4.2.1). Objects with these additions from the Create (signed) route are failing to verify.

This PR is intended to:

  • Unify CoRIM's code for Create (unsigned) and Create (signed), while maintaining additional fields for CoRIM (i.e. corim-meta-map)
  • Add respective tests to the corim_comid_tests.sh script to test both routes
  • Point to an updated HIRS main branch to use as submodule, now that [RIM-Tool #41]: Modify CoRIM signing for RIM-Tool bugfix HIRS#1173 is merged

To test, run src/test/scripts/corim_comid_tests.sh, or run_all_tests.sh if desired.

Resolves #41

@iadgovuser62 iadgovuser62 marked this pull request as ready for review April 20, 2026 13:49
@iadgovuser26 iadgovuser26 merged commit a91aa28 into main May 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streamline code for signing CoRIMs

2 participants