Require matplotlib < 3.8 for pgf.common_texification
#597
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn'it it be nicer to have an actual fix instead? |
|
It would, but I don't have time to prepare an actual fix right now, and this is an easy patch to revert when a fix lands, and I don't think breaking pip's solver on this package while we wait for a fix(/wait to find time to fix it) is a good idea. Note that I didn't mark this PR as fixing the corresponding issue, and I don't think it makes sense to close that issue until a proper fix lands. |
XxSonicGhostxX
suggested changes
Mar 2, 2024
It seems there are a bunch of fixes for this in the wild that have not been turned into PRs, e.g., RobertDeibel#2, lukashof@9eddaba, lucaslrodri@860e4a5 |
|
I created a PR #602. But I think it's been a while since something got merged, unfortunately. |
JasonGross
added a commit
to JasonGross/tikzplotlib
that referenced
this pull request
Apr 12, 2024
Work around matplotlib/matplotlib@1936c94 Fixes nschloe#559 Closes nschloe#602 Closes nschloe#597 Overalps a bit with nschloe#540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #559