Fix the cIGZSystemService definitions

[0xC0000054]

OnTick and OnIdle take a single integer parameter, which appears to be
some kind of incrementing counter.
The cIGZSystemService header was also missing the GetServiceTickPriority method, which
was causing it to crash when calling AddToTick.

Fixed the OnTick and OnIdle method signatures in various headers.

[nsgomez]

@0xC0000054 thanks for the PRs! I think the parameter is supposed to be the total number of tick and idle frames that have elapsed since the game started. At least that's what I've been able to deduce from reverse-engineering in https://github.com/nsgomez/scion

Declaration I used there: https://github.com/nsgomez/scion/blob/main/src/framework/include/cIGZSystemService.h

Usage: https://github.com/nsgomez/scion/blob/f0608f01e058b2e97e7d94225f02047d84573a8d/src/framework/src/cGZFramework.cpp#L490

[0xC0000054]

That makes sense. How is scion supposed to be used for reverse engineering?

I see that it uses a version of STLPORT, are scion's collection types (std::list, etc.) binary compatible with SC4?
As I mentioned in #8, the EASTL vector type is binary compatible with SC4 but its list type is not.

[nsgomez]

Scion is a bottom-up reverse engineering of the GZ/RZ game framework, including source code. gzcom-dll is more top-down, starting with SimCity 4's game-specific bits and working down, and mostly focuses on declaring interfaces instead of reversing the source wholesale. You could smush them together by replacing gzcom-dll's GZCOM declarations with the ones from Scion.

And yeah, SimCity 4 (on Windows) uses STLPORT instead of EASTL or the compiler-provided STL. If you inspect SimCity 4.exe in a PE viewer, there's a program section referencing it:

So you should have better luck using that instead.