ci: add ShellCheck, shfmt, and editorconfig-checker#11
Merged
Conversation
nsheaps
commented
Feb 24, 2026
Owner
Author
nsheaps
left a comment
nsheaps
left a comment
There was a problem hiding this comment.
QA Review: 91/100 ✅ — Ready to merge
Reviewer: Daffy D (qa)
Category Scores
| Category | Score | Status |
|---|---|---|
| Simplicity | 92 | ✅ |
| Flexibility | 90 | ✅ |
| Usability | 90 | ✅ |
| Documentation | 88 | ✅ |
| Security | 90 | ✅ |
| Pattern Matching | 92 | ✅ |
| Best Practices | 90 | ✅ |
| General QA | 92 | ✅ |
Findings
- pattern-1 (P3): Push-only trigger — consistent with dotfiles#8, not a defect.
- bp-1 (P3): SC2034 disabled globally in
.shellcheckrc— could mask real unused-variable bugs. Per-file disable more precise. - security-1 (P3):
editorconfig-checker/action-editorconfig-checker@mainpinned to branch, not SHA.
Verified Correct
- Concurrency group uses
github.ref/github.sha— nopull_request.number(dotfiles#8 P1 avoided) - shfmt reads
.editorconfig— no hardcoded flags (dotfiles#8 P2 avoided) - All shell script changes are formatting-only (case indent, variable assignment style)
.editorconfighas[*.sh]withswitch_case_indent = true- mise.toml uses explicit file list (cleaner than find-based approach for small repos)
- No secrets or hardcoded paths
Ready to merge.
Add P1 consistency items matching org standard:
- .shellcheckrc with SC1091 and SC2034 disabled
- .editorconfig with shell script settings for shfmt
- .github/workflows/check.yaml (ShellCheck + shfmt + editorconfig-checker)
- Updated mise.toml with fmt, fmt-check, and improved lint/check tasks
- Applied shfmt formatting to all bash scripts
- Fixed SC2155 warnings (separate local declarations from assignments)
- Added inline SC2016/SC2001 disables for intentional patterns
Co-Authored-By: Claude Code (User Settings, in: ${CLAUDE_PROJECT_DIR}) <noreply@anthropic.com>
nsheaps
force-pushed
the
p1-consistency
branch
from
da022ff to
f21ffa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.shellcheckrc(SC1091, SC2034 disabled).editorconfigwith[*.sh]section for shfmt settings.github/workflows/check.yaml(ShellCheck + shfmt + editorconfig-checker)mise.tomlwithfmt,fmt-check, and improvedlint/checktasksbin/git-wtandtest/cli-test.shPart of org-wide P1 consistency pass.
Test plan
mise run checkpasses locally🤖 Generated with Claude Code