nsqd: switch to Klaus Post's flate compression library #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Close sockets to ensure timely shutdown. This is the major improvement. Without this benchmarks would regularly time out - Switch to a logger with no output to make the benchmark output readable - Fix one unix socket benchmark to use unix socket opening function - Fixed BenchmarkGUID to be a valid test - and added a similar TestGUID With these changes I've also found I need to restrict b.N or NSQD takes too long to exit when N gets large. I've seen this in tests that publish only and do not receive messages. A large number of messages then need to be persisted and this takes tens of seconds. Once these changes are made `go test -bench . -run ^$ -benchtime 1000x` completes cleanly for me.
This is a dropin replacement for the standard library flate compression.
mreiferson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dropin replacement for the standard library flate compression.
In addition to this I've also
To really get the benefits of improving compression for go-nsq users we also need the same change in go-nsq. I've got a draft pull request here: nsqio/go-nsq#363
Similarly snappy performance needs nsqio/go-nsq#362