Skip to content

Commit

Permalink
Fix dict key name
Browse files Browse the repository at this point in the history
  • Loading branch information
PedroKoch committed Dec 7, 2023
1 parent a302d91 commit 62e701d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/fklearn/training/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ def pipeline(data: pd.DataFrame) -> LearnerReturnType:
current_data = new_data

model_objects = {}
if learner_log.get("obj"):
model_objects["obj"] = learner_log.pop("obj")
if learner_log.get("object"):
model_objects["object"] = learner_log.pop("object")

serialisation[learner_name].append({"fn": learner_fn, "log": learner_log, **model_objects})
logs.append(learner_log)
Expand Down
8 changes: 4 additions & 4 deletions tests/training/test_pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def dummy_learner_2(df, fn, call):

@fp.curry
def dummy_learner_3(df, fn, call):
return fn, df, {f"dummy_learner_{call}": {}, "obj": "a"}
return fn, df, {f"dummy_learner_{call}": {}, "object": "a"}

train_fn = build_pipeline(
dummy_learner(fn=fn, call=1),
Expand All @@ -166,10 +166,10 @@ def dummy_learner_3(df, fn, call):
"features": ['id', 'x1', 'y'],
"learners": {"dummy_learner": {"fn": fn, "log": {"dummy_learner_1": {}}},
"dummy_learner_2": {"fn": fn, "log": {"dummy_learner_2": {}}},
"dummy_learner_3": {"fn": fn, "log": {"dummy_learner_3": {}}, "obj": "a"}}}
"dummy_learner_3": {"fn": fn, "log": {"dummy_learner_3": {}}, "object": "a"}}}

assert log["__fkml__"] == fkml
assert "obj" not in log.keys()
assert "object" not in log.keys()


@pytest.mark.parametrize("has_repeated_learners", [False, True])
Expand Down Expand Up @@ -247,4 +247,4 @@ def dummy_learner_2(df, fn, call):
"dummy_learner_2": [{"fn": fn, "log": {"dummy_learner_2": {}}}]}}

assert log["__fkml__"] == fkml
assert "obj" not in log.keys()
assert "object" not in log.keys()

0 comments on commit 62e701d

Please sign in to comment.