Imputer fill_value

[vitorsrg]

Status

READY

Todo list

• Documentation
• Tests added and passed
• Issue: closes Missing features removal with SimpleImputer #124

Description of the changes proposed in the pull request

• add fill_value to imputer
• add to .gitignore some files created by the tests

[vitorsrg]

For reference: #125

[gabrielvcbessa]

Nice job! I left just one comment regarding tests.

[prcastro]

Nice job! Left some comments on thing to fix before we merge.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@04f361a). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #126   +/-   ##
=========================================
  Coverage          ?   94.84%           
=========================================
  Files             ?       25           
  Lines             ?     1592           
  Branches          ?      221           
=========================================
  Hits              ?     1510           
  Misses            ?       49           
  Partials          ?       33

Impacted Files	Coverage Δ
src/fklearn/training/imputation.py	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f361a...521074e. Read the comment docs.

already fixed

[gppeixoto]

i won't block the merge, but i strongly recommend to use pandas assertions instead of assert and equals. good job on the fixes 💯 @vitorsrg