Skip to content

fix(pm): tolerate optional-only build failures - #726

Draft
colinhacks wants to merge 1 commit into
mainfrom
optional-build-failure-parity
Draft

fix(pm): tolerate optional-only build failures#726
colinhacks wants to merge 1 commit into
mainfrom
optional-build-failure-parity

Conversation

@colinhacks

Copy link
Copy Markdown
Contributor

Summary

  • Continue an install when an approved lifecycle script fails for a package reachable only through optional dependency edges.
  • Derive optionality from the dependency graph so frozen npm, Bun, and Yarn lockfiles behave the same as fresh resolutions.
  • Keep failures fatal when the package has any required path, and report skipped builds through WARN_NUB_OPTIONAL_BUILD_FAILED.

Verification

  • XDG_CONFIG_HOME=$(mktemp -d) make verify
  • cd vendor/aube && cargo test -p aube --test e2e
  • Built target/fast/nub and verified both optional-only and required sibling builds in a clean fixture.
  • Installed and approved @bahmutov/add-typescript-to-cypress@2.1.2 in a clean hoisted consumer fixture; the published postinstall created both Cypress plugin files.

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nub Ready Ready Preview Aug 12, 2026 5:33pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant