Closed
Conversation
Passing just text is good but passing the entire element allow more flexibility, i.e. one can know on what link user clicked
Contributor
|
@sleewoo - However, there is a bug, because it is only passed when an item is selected using a mouse, not the keyboard. #16795 fixes this, but have not been accepted yet. |
Author
|
thanks, somehow missed |
ghost
deleted the
patch-1
branch
January 9, 2016 17:51
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing just text is good but passing the entire element allow more flexibility, i.e. one can know on what link user clicked