-
Notifications
You must be signed in to change notification settings - Fork 13
reset csv buffer upon upload retries in predict.py, updated numerblox to fix py3.10 on pandas-ta
#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where CSV buffer reuse during upload retries could cause issues by creating a fresh buffer on each retry attempt instead of reusing a shared one.
- Refactored CSV generation to create payload once and generate fresh buffers per retry
- Updated buffer creation from StringIO to BytesIO for proper encoding handling
- Added comprehensive test coverage to verify buffer isolation between retry attempts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| predict.py | Refactored to create fresh BytesIO buffer on each retry instead of reusing StringIO |
| tests/test_predict.py | Added test coverage for retry behavior with buffer isolation verification |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ded numerblox on 3.11 and 3.12
…edict into josh/reset-csv-buffer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 12 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
predict.pypredict.py, updated numerblox to fix py3.10 on pandas-ta
No description provided.