Skip to content

Conversation

@joshterrill
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings September 28, 2025 22:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where CSV buffer reuse during upload retries could cause issues by creating a fresh buffer on each retry attempt instead of reusing a shared one.

  • Refactored CSV generation to create payload once and generate fresh buffers per retry
  • Updated buffer creation from StringIO to BytesIO for proper encoding handling
  • Added comprehensive test coverage to verify buffer isolation between retry attempts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
predict.py Refactored to create fresh BytesIO buffer on each retry instead of reusing StringIO
tests/test_predict.py Added test coverage for retry behavior with buffer isolation verification

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
Copilot AI review requested due to automatic review settings September 28, 2025 22:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@joshterrill joshterrill requested a review from Copilot September 29, 2025 07:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 12 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@joshterrill joshterrill changed the title reset csv buffer upon upload retries in predict.py reset csv buffer upon upload retries in predict.py, updated numerblox to fix py3.10 on pandas-ta Sep 29, 2025
@joshterrill joshterrill merged commit 10e2fec into master Oct 23, 2025
4 checks passed
@joshterrill joshterrill deleted the josh/reset-csv-buffer branch October 23, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants