Skip to content

Conversation

charris
Copy link
Member

@charris charris commented Oct 11, 2025

No description provided.

@charris charris closed this Oct 14, 2025
@charris charris reopened this Oct 14, 2025
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks fine to me, should do the job. Build logs show it builds 2.3.4, that's because the .dev0 gets dropped from the visible logging.

Should be good to merge if CI comes back green.

@charris
Copy link
Member Author

charris commented Oct 14, 2025

Build logs show it builds 2.3.4

It did that even before it was tagged. I think it got that version from the pyproject.toml file.

@charris
Copy link
Member Author

charris commented Oct 14, 2025

@rgommers I updated cibuildwheel, missed that. I'm thinking it might be worth adding dependabot just to track updates in the wheels.yml file. Keeping the requirements/license files in sync also needs a procedure. I did check the requirements files here, but they might have changed in main.

EDIT: Or maybe just figure out how to keep the requirements in numpy.

@rgommers
Copy link
Member

I'm thinking it might be worth adding dependabot just to track updates in the wheels.yml file.

numpy/numpy#29462 (comment)

Keeping the requirements/license files in sync also needs a procedure. I did check the requirements files here, but they might have changed in main.

Indeed, see gh-6.

EDIT: Or maybe just figure out how to keep the requirements in numpy.

That wouldn't be good. The requirements here are the minimal build/test requirements and 100% of them are pinned. Part of the point of this repo is to minimize what gets pulled in to reduce the supply chain security surface.

I'm thinking more like a check that runs before the wheel builds kick off that checks the important ones (OpenBLAS in particular) for equality between this repo and the main repo. I'll have a look at it now.

@rgommers rgommers merged commit 989feee into numpy:maintenance/2.3.x Oct 15, 2025
78 checks passed
@rgommers
Copy link
Member

For completeness: there are no overlapping license files, the ones needed for NumPy sources are only in the main repo, the ones needed for vendoring/distributing are only in this repo.

@charris charris deleted the test-wheels branch October 15, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants