-
-
Notifications
You must be signed in to change notification settings - Fork 9
Implement hyperbolic ufuncs #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@SwayamInSync Once we've figured out a way to handle the trigonometric ufuncs correctly, I'd like to add the hyperbolic ones as well - but I'll wait with writing tests until we have the trigonometric ones figured out |
Got it, thanks @juntyr |
3072aba
to
8ce15a0
Compare
@SwayamInSync Since the hyperbolic ufuncs don't have the same issues as the trigonometric ones, I wanted to get this PR over the line first. I've also added more tests for -0.0 inputs and fixed min/max for them. |
Hmm... hyperbolic were also defined as summation variants of exponentials, did you confirm that they don't have the same problem as #126 on very large inputs say 1e100 or something? |
Let's try that! |
@SwayamInSync So sinh, cosh, tanh, and arctanh handle the large inputs as our tests expect. But for arcsinh and arccosh the floating result can overflow while the quad result doesn't yet. How would you suggest that we check that? |
1e1000 and + are beyound float limits, we are good if they are working till one big common range i.e. |
Add hyperbolic ufunc tests Add more tests for -0.0 Guarantee that min/max are zero-sign-sensitive
@SwayamInSync From my end this should be ready to be merged now :) |
Merging it, thanks @juntyr |
sinh
,cosh
,tanh
,arcsinh
,arccosh
, andarctanh
ufuncs-0.0
minimum
,maximum
,fmin
,fmax