Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information to explicit tests #1017

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Add information to explicit tests #1017

merged 8 commits into from
Feb 11, 2025

Conversation

OsirisTerje
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 9, 2025

@@ -38,9 +38,32 @@ However, the following options will **not** include explicit tests
--where cat!=X
```

## TRAP
Copy link
Member

@SeanKilleen SeanKilleen Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OsirisTerje is it your intention to provide a warning here? If so I can update the formatting accordingly. Unsure the purpose of using TRAP

Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍 Once @OsirisTerje answers my last minor question and we fix up the heading if necessary, this should be good to go in.

@SeanKilleen SeanKilleen merged commit e41eb5b into master Feb 11, 2025
7 checks passed
@SeanKilleen SeanKilleen deleted the explicittests branch February 11, 2025 02:13
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
* Add information to explicit tests

* Add information to explicit tests

* Add information to explicit tests

* update

* Linting fixes

* Auto-fix markdownlint issues

---------

Co-authored-by: Sean Killeen <[email protected]> e41eb5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants