-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated installation instructions #793
Conversation
@SeanKilleen Not sure why the site build fails, can you have a look? |
So that it can be cross-referenced by ID rather than path
Should resolve the other xref warning
@OsirisTerje the build was failing because there were docfx warnings upon generation which would have resulted in dead links, so we fail the build on those. The build output is a bit verbose because of all the legacy docs, but if you go into the GitHub actions output and search for
This means you're using an The solution is to give those pages |
docs/articles/nunit/getting-started/dotnet-core-and-dotnet-standard.md
Outdated
Show resolved
Hide resolved
docs/articles/nunit/getting-started/dotnet-core-and-dotnet-standard.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: Sean Killeen <[email protected]>
…ndard.md Co-authored-by: Sean Killeen <[email protected]>
docs/articles/nunit/getting-started/dotnet-core-and-dotnet-standard.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM! Thanks for the overhaul!
* Updated installation instructions * Updated installation instructions * give a UID to the installation page So that it can be cross-referenced by ID rather than path * Add uid for nunit lite runner Should resolve the other xref warning * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/installation.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/dotnet-core-and-dotnet-standard.md Co-authored-by: Sean Killeen <[email protected]> * Update docs/articles/nunit/getting-started/dotnet-core-and-dotnet-standard.md * convert to note * convert to note * change markdown to use xml --------- Co-authored-by: Sean Killeen <[email protected]> 257a56c
Updated the installation instructions to be up-to-date with how things are done in 2023.