Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for nunit 4.2 #956

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Update for nunit 4.2 #956

merged 5 commits into from
Aug 12, 2024

Conversation

OsirisTerje
Copy link
Member

No description provided.

Copy link

github-actions bot commented Aug 4, 2024

Copy link
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these @OsirisTerje
I found a few quick links or references to update. I think I should be able to push changes as "suggestions"

docs/articles/nunit/release-notes/framework.md Outdated Show resolved Hide resolved
docs/articles/nunit/release-notes/framework.md Outdated Show resolved Hide resolved
@@ -51,6 +54,17 @@ None

### Others

* [4765](https://github.com/nunit/nunit/issues/4765) Document ThrowOnEachFailurUnderDebugger.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: This would be a documentation update to the docs repo in support of nunit/nunit#4738 above. Do we also track these as framework release notes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. I would prefer to have these issues in the docs repo, but up to now we have had them in the code repos. There are area labels in the docs repo that could be used to point to the right source.
Since I generate the release notes and it has the milestone, it is picked up.

@manfred-brands
Copy link
Member

manfred-brands commented Aug 5, 2024

I created 1 documentation issue:

EnterMultipleScope

Are there any others that need documenting?

Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this LGTM 👍

@OsirisTerje OsirisTerje merged commit 5958c84 into master Aug 12, 2024
7 checks passed
@OsirisTerje OsirisTerje deleted the releasenotesNunit42 branch August 12, 2024 12:45
github-actions bot pushed a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants