Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating packaging info #969

Merged
merged 6 commits into from
Aug 22, 2024
Merged

updating packaging info #969

merged 6 commits into from
Aug 22, 2024

Conversation

OsirisTerje
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

Preview link: https://66c764c685fd075a9d7bfdb6--resilient-maamoul-8b1e0d.netlify.app

SeanKilleen
SeanKilleen approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Only one comment

@OsirisTerje
Copy link
Member Author

@SeanKilleen Can you please have a look at the linting issue, it is something with the ordered list and then it complains about line length, which should not be an issue for an ordered list. I can't break the line there, then I get another entry.

@SeanKilleen
Copy link
Member

SeanKilleen commented Aug 22, 2024 •
edited
Loading

@OsirisTerje to fix this, did the following:

  • Clicked to open this branch in a GitHub codespace
  • Let the codespace load in the browser
  • Ran lint in the terminal
  • Clicked on where the errors were surfaced
  • Looked at the visual guideline (provided by the codespace environment plugin) to see where things were over the line
  • Hit enter where the item was over the line to start a new line
  • Made sure there were no trailing spaces
  • Ran serve to ensure that there were no additional bullets added by my change

All good now 👍

@SeanKilleen SeanKilleen merged commit d6bea1d into master Aug 22, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 22, 2024
@SeanKilleen
updating packaging info (#969)
305a61b 
* updating packaging info

* updating packaging info

* Update docs/articles/developer-info/Packaging-the-Framework.md

Co-authored-by: Sean Killeen <[email protected]>

* updating packaging info

* fix linting

* another line spacing adjustment

---------

Co-authored-by: Sean Killeen <[email protected]> d6bea1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanKilleen SeanKilleen SeanKilleen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OsirisTerje @SeanKilleen