Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trivia for NUnit2007 #782

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix trivia for NUnit2007 #782

merged 1 commit into from
Sep 12, 2024

Conversation

verdie-g
Copy link
Contributor

@verdie-g verdie-g commented Sep 11, 2024 •
edited by manfred-brands
Loading

Fixes #783

Appyling NUnit2007 on

Assert.AreEqual(Environment.ProcessorCount,
    1);

would give

Assert.AreEqual(    1,
Environment.ProcessorCount);

manfred-brands
manfred-brands approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verdie-g Thanks for your contribution. Changes look good and test case provided.

@manfred-brands manfred-brands merged commit 8b2e749 into nunit:master Sep 12, 2024
6 checks passed
@mikkelbu mikkelbu added this to the Release 4.4 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manfred-brands manfred-brands manfred-brands approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 4.4
Development

Successfully merging this pull request may close these issues.

NUnit2007 doesn't apply trivia correctly
3 participants
@verdie-g @manfred-brands @mikkelbu