Detect more Classic Assert #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkelbu
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Great work @manfred-brands. I've added some minor comments/questions, but I'm happy to merge this when you are.
src/nunit.analyzers.tests/ClassicModelAssertUsage/ClassicModelAssertUsageAnalyzerTests.cs
Show resolved
Hide resolved
src/nunit.analyzers.tests/ClassicModelAssertUsage/ClassicModelAssertUsageAnalyzerTests.cs
Show resolved
Hide resolved
...alyzers.tests/ClassicModelAssertUsage/IsAssignableFromClassicModelAssertUsageCodeFixTests.cs
Outdated
Show resolved
Hide resolved
...alyzers.tests/ClassicModelAssertUsage/IsAssignableFromClassicModelAssertUsageCodeFixTests.cs
Show resolved
Hide resolved
|
Thanks @mikkelbu for your review and my apologies for some obvious rushed changes. |
|
There is absolutely no need to apologise - my comments were the smallest of nit-picks and your contributions the last couple of years are the primary reason that this project has moved forward. So I'm just happy for all of the work that you have put into this repo. I'll see if I can get a release out tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #789 Assert.Positive, Assert.Negative
Fixes #790 Assert.IsAssignableFrom, Assert.IsNotAssignableFrom