Skip to content

[14.0][ADD] mgmtsystem_review_copy_lines - #931

Open
deeniiz wants to merge 1 commit into
14.0from
14.0-add-mgmtsystem_review_copy_lines
Open

[14.0][ADD] mgmtsystem_review_copy_lines#931
deeniiz wants to merge 1 commit into
14.0from
14.0-add-mgmtsystem_review_copy_lines

Conversation

@deeniiz

@deeniiz deeniiz commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Duplicating a management system review now also duplicates its review lines
    (title, type, linked action/nonconformity and decision), so a review can be
    kept as a template and duplicated instead of re-entering its structure.
  • Every duplicate starts in the Open state, even when the source review is
    closed — avoiding copies born closed and read-only.
  • Reference assignment is unchanged: each copy still gets a fresh sequence reference.

Test plan

  • pre-commit passes locally (black, isort, flake8, pylint_odoo, oca-gen-addon-readme)
  • CI green
  • Manual test (UI / Playwright, dev DB): duplicating a template copies all
    lines with decision + linked action, fresh reference, disjoint line ids;
    duplicating a closed review yields an open, editable copy
  • Unit tests executed in runtime (pending: dev role lacks CREATEDB; covered by CI)

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.31%. Comparing base (e066126) to head (92da6c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             14.0     #931      +/-   ##
==========================================
+ Coverage   51.26%   51.31%   +0.05%     
==========================================
  Files        1180     1185       +5     
  Lines       20388    20420      +32     
  Branches     4298     4301       +3     
==========================================
+ Hits        10451    10479      +28     
- Misses       9683     9686       +3     
- Partials      254      255       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@deeniiz
deeniiz force-pushed the 14.0-add-mgmtsystem_review_copy_lines branch from 8810eb1 to 0a16a8d Compare June 15, 2026 08:00
Duplicating a management system review did not carry over its lines, since
One2many fields are not copied by default; reusing a review as a template
meant re-entering every line by hand. Make the review lines copyable and
force every duplicate to start in the open state, so even a closed review
duplicates into a fresh, editable copy. Enables a template-based workflow
for recording change controls with low operational overhead.
@deeniiz
deeniiz force-pushed the 14.0-add-mgmtsystem_review_copy_lines branch from 0a16a8d to 92da6c1 Compare June 15, 2026 08:03
@deeniiz
deeniiz requested a review from eantones June 15, 2026 08:09
@deeniiz
deeniiz removed the request for review from eantones June 15, 2026 08:30
@deeniiz
deeniiz requested a review from eantones June 15, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants