Skip to content

[14.0][IMP] connector_woocommerce: export product template/variant by Od… - #938

Closed
deeniiz wants to merge 1 commit into
14.0from
14.0-imp-connector_woocommerce-export_by_odoo_id
Closed

[14.0][IMP] connector_woocommerce: export product template/variant by Od…#938
deeniiz wants to merge 1 commit into
14.0from
14.0-imp-connector_woocommerce-export_by_odoo_id

Conversation

@deeniiz

@deeniiz deeniiz commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

…oo id

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.49%. Comparing base (89b9375) to head (e2ed8e6).

Files with missing lines Patch % Lines
...ctor_woocommerce/models/product_product/binding.py 25.00% 3 Missing ⚠️
...tor_woocommerce/models/product_template/binding.py 25.00% 3 Missing ⚠️
connector_woocommerce/models/backend/backend.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             14.0     #938      +/-   ##
==========================================
- Coverage   51.49%   51.49%   -0.01%     
==========================================
  Files        1182     1182              
  Lines       20438    20446       +8     
  Branches     4299     4301       +2     
==========================================
+ Hits        10524    10528       +4     
- Misses       9658     9663       +5     
+ Partials      256      255       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@deeniiz
deeniiz force-pushed the 14.0-imp-connector_woocommerce-export_by_odoo_id branch from 1aa3bf8 to 843ece3 Compare July 2, 2026 07:41
@deeniiz
deeniiz requested a review from eantones July 2, 2026 08:30
@deeniiz
deeniiz force-pushed the 14.0-imp-connector_woocommerce-export_by_odoo_id branch from 843ece3 to a6c0171 Compare July 2, 2026 09:51
@deeniiz deeniiz changed the title [14.0][IMP] connector_woocommerce: export product template/sale order by Od… [14.0][IMP] connector_woocommerce: export product template/variant by Od… Jul 2, 2026
@deeniiz deeniiz added this to the 12.0 milestone Jul 2, 2026
@deeniiz
deeniiz force-pushed the 14.0-imp-connector_woocommerce-export_by_odoo_id branch from a6c0171 to a095969 Compare July 2, 2026 12:18
@deeniiz
deeniiz force-pushed the 14.0-imp-connector_woocommerce-export_by_odoo_id branch from a095969 to e2ed8e6 Compare July 3, 2026 11:24
@eantones

eantones commented Jul 4, 2026

Copy link
Copy Markdown
Member

Closing without merge — decision by Eric (2026-07-04), documented in Odoo task #2711. The work is good and tested, but:

  1. The need is already covered by the existing woocommerce_enabled flag on the product (computed from Published but stored and manually editable). The connector's export binding domain only picks products with the flag set — so for punctual per-product test exports, enabling the flag on just the product(s) under test gives the same control with no new code.
  2. Backend cleanliness: a permanent export-by-ID control adds debug-only surface to the standard production backend. If we ever need this tooling again, it should live in a separate opt-in module (e.g. connector_woocommerce_debug) installed only while debugging and uninstalled afterwards.
  3. The underlying production issue (duplicated products for items already existing in WC) is properly fixed in [14.0][FIX] connector_woocommerce: relink already existing products on export #941, which is where the effort goes now.

Thanks Deniz — the relink fix (#941) is the valuable piece here and is under review.

@eantones eantones closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants