[16.0][FWP][IMP] l10n_es_extension: add the generic non-deductible VAT family - #955
Open
eantones wants to merge 5 commits into
Open
[16.0][FWP][IMP] l10n_es_extension: add the generic non-deductible VAT family#955eantones wants to merge 5 commits into
eantones wants to merge 5 commits into
Conversation
Regenerate the module's README artifacts with the repository's pinned oca-gen-addon-readme: the committed files were stale against the readme sources and the current generator output (old digest, author name split by the comma, missing description bullet and OCA banner).
(cherry picked from commit 9df4512)
The goods variants (bienes corrientes / bienes de inversion) and the intra-community / reverse-charge cases of the non-deductible input VAT are generic to the Spanish localization, but the official l10n_es only ships the four servicios corrientes templates (4%, 5%, 10% and 21% -- the latter under its historical xml-id p_iva0_nd). Declare the missing family here: 15 tax templates, the name overrides of the four official ones, and the mapping lines that plug them into the official intra-community and IRPF 15 fiscal positions, following the same pattern l10n_es_special_prorate uses for its prorate taxes. The records are a faithful copy of the ones oxigen_l10n_es declared until now (they were born there in 2022, but they are not client-specific). The terminal xml-id names are kept identical on purpose: the oxigen_l10n_es 14.0.1.1.0 migration relies on them to hand over the existing records in place, and the template synchronization of later Odoo versions pairs records by name. (cherry picked from commit cebdd1a)
…ition The official 'No sujeto por reglas de localizacion (TAI)' fiscal position only maps the deductible taxes to their no-sujeto counterparts; the non-deductible family must fall the same way. Add the nine mapping lines (servicios / bienes corrientes / bienes de inversion at 4%, 10% and 21%) to the official position template. Forward-port note: the 14.0 migration that materialized the missing lines on existing companies is not carried; on 16.0 the mapping lines reach existing companies through the chart update wizard, which remains the standard vehicle for chart data. (cherry picked from commit 40ac75b25f207683fa2696a51050b6ffe86a92ff)
eantones
added
the
no merge before Oxigen 18
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16.0 #955 +/- ##
=======================================
Coverage 54.14% 54.14%
=======================================
Files 339 339
Lines 6959 6959
Branches 1035 1035
=======================================
Hits 3768 3768
Misses 3055 3055
Partials 136 136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…aming
The four official ND templates this module renames (4%/5%/10%/21%,
disambiguated as "(servicios corrientes)") kept the 14.0 wording, with
the percent after the concept; 16.0 names its officials percent-first
("4% IVA Soportado no deducible"). Restyle the four override strings to
the 16.0 convention so fresh-16 dropdowns stay consistent; the
disambiguating surname is unchanged. Existing databases are untouched:
the override is template data only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of the generic non-deductible VAT family from 14.0 (#953) to 16.0, plus the exempt-without-deduction-right output VAT that 16.0 never received.
[IMP] l10n_es_extension: pre-commit auto fixes— the committed README artifacts were stale against the readme sources and the pinned generator (old digest, author name split by the comma, missing OCA banner).s_iva0override +s_iva0_sdd(merged on 14.0, missing here: the 16.0 module shipped withoutaccount_tax_data.xml).All
l10n_esreferences used by the data files exist on 16.0 with the same xml-ids (mod303 tags, 472/477 accounts, tax groups, fiscal positions, official templates); the data files are identical to the 14.0 ones at #953 head.Review note: the name overrides keep the 14.0 wording ("IVA Soportado no deducible 4% (servicios corrientes)") while the 16.0 official style is percent-first ("4% IVA Soportado no deducible"). The disambiguation suffix is the point of the override; the style can be aligned if preferred.
Do not merge until Oxigen is live in production on 18.0: the 14→18 migration chain consumes this branch via refs/pull, and merging early would change what the chain loads.