refactor(nu-hooks/startup-times): Better performance and UX #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Bahex
commented
Jun 16, 2025
Bahex
commented
- Use attr based examples.
- Hook removes itself after running, rather than staying loaded.
- Switch to tsv as storage format to allow adding new logs without loading the file into memory.
|
Seems reasonable. I've ran a custom version of this since Aug-2023. My windows system is horribly slow but here's what I do with the output of a script like this one. I thought "perf per byte" would be a reasonable way to measure performance since everyone sources/uses different files at startup. I could share my startup-stats script too if anyone is interested. |
- Use attr based examples - Hook removes itself after running, rather than staying loaded. - Switch to tsv as storage format to allow adding new logs without loading the file into memory.
…urning it as a record
Bahex
force-pushed
the
nu-hooks/startup-time
branch
from
df57033 to
db40323
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.