-
Notifications
You must be signed in to change notification settings - Fork 297
Extend dotnet completions documentation #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
.NET 10 introduces `dotnet completions script nushell`. I took the opportunity to try and update the dotnet completions, to test if it works and what works, but ultimately concluded that it's incomplete/unusable as is. I updated the README.md with my findings. I assume `dotnet complete` is currently missing and will be extended with `dotnet completions` completions eventually. I'm not sure whether the current extern export is preferable over an external completer configuration, but it seems plausibly preferable to me, because it doesn't mix with other external completer configurations and is used earlier in the completion chain before falling back to external completers. If that is the case, the dotnet command generates suboptimal completion configuration.
| ## .NET SDK 10 and `dotnet completions` | ||
|
|
||
| From the .NET SDK version 10 onwards, the `dotnet` CLI offers `dotnet completions script nushell` which generaltes a Nushell external completer configuration, | ||
| but in an outdated format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- end line in comma then start the last part of a sentence on a new line?
- the last line isn't what i'd call helpful. the original syntax just needs to be figured out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown won't render the newline.
the original syntax just needs to be figured out
I don't get what you mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm saying what was previously there would probably work if it were updated to $env.config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I had there previously is the output from dotnet. Changing the code would defeat the purpose of showing what dotnet prints out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having non-working code in the help is also defeating the purpose. We need a PR to the dotnet repo too to fix their incorrect AI.
.NET 10 introduces
dotnet completions script nushell.I took the opportunity to try and update the dotnet completions, to test if it works and what works, but ultimately concluded that it's incomplete/unusable as is.
I updated the README.md with my findings.
I assume
dotnet completeis currently missing and will be extended withdotnet completionscompletions eventually.