-
Notifications
You must be signed in to change notification settings - Fork 191
feat: new ReedlineEvent::PartialComplete event
#967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| // If the values were already updated (e.g. quick completions are true) | ||
| // there is no need to update the values from the menu | ||
| if !values_updated { | ||
| self.update_values(editor, completer); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very sure that it's safe to remove this. But I think it's a bad idea to handle quick completion related menu updates here.
|
Are there tests we can add for this plus the quick complete section that was removed? |
That's a good question.
reedline/src/menu/columnar_menu.rs Lines 773 to 795 in 22768f3
|
Move the partial completion logic from the handling of
ReedlineEvent::MenuNext, so that we can fix nushell/nushell#14152 while keeping the following behavior.Closes #881