chore: update tree-sitter; remove dead rust code#5
chore: update tree-sitter; remove dead rust code#5notpeter wants to merge 3 commits intonusnewob:mainfrom
Conversation
- Removed the rust code as it was currently a no-op. - Update adds HEREDOC support and other fixes too. - tree-sitter diff: caddyserver/tree-sitter-caddyfile@a599a9c...462aa78
| [grammars.caddyfile] | ||
| repository = "https://github.com/caddyserver/tree-sitter-caddyfile.git" | ||
| commit = "a599a9ca6729d4a115f59a7f12247e86e9a78008" | ||
| commit = "8951716aa2855e02dada302c540a90f277546095" |
There was a problem hiding this comment.
based on my testing, new commits after this breaks syntax highlighting.
There was a problem hiding this comment.
Awesome. I've rolled back to caddyserver/tree-sitter-caddyfile@462aa78
which works for me, but still breaks if snippets and sites are intermingled as I described here caddyserver/tree-sitter-caddyfile#52 but an improvement over the current state.
This reverts commit 4d8c7ee.
|
It still fails to recognise snippets and sites mixed config based on my test using https://github.com/nusnewob/caddyfile-zed/blob/main/test/Caddyfile |
|
Yep. Upstream opted to not merge caddyserver/tree-sitter-caddyfile#52 and claimed it was fixed in caddyserver/tree-sitter-caddyfile@8951716. I'm going to ahead and close. Still probably worth removing Cargo.lock,Cargo.toml,src/lib.rs -- they are a no-op and not required for language extensions that only provide tree-sitter languages but no LSP. |
|
@notpeter I forked the upstream and appllied it with my own fix, let's see if they'll merge it. I know the rust code doesn't do anything, it was kept in there just for placeholder, if someone creates a caddy LSP |
2 participants
Uh oh!
There was an error while loading. Please reload this page.