Skip to content

feat: use registryMirror addon as Containerd mirror #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dkoshkin/feat-registry-mirror-addon
Choose a base branch
from

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented May 2, 2025

What problem does this PR solve?:
Depends on #1116

Automatically sets the registryMirror as a Containerd mirror. We're not updating the Cluster object because this should not be a user controller configuration and the IP used as the mirror is determined based on the addon handler and the Service CIDRs.

Tested in a Docker cluster:

$ kubectl port-forward \
  --address=0.0.0.0 \
  --namespace registry-mirror-system \
  pod/registry-mirror-docker-registry-0 5000:5000
# Push an image tag that doesn't exist in dockerhub  
$ crane copy nginx:latest 0.0.0.0:5000/library/nginx:dkoshkin --insecure
$ kubectl run nginx-working --image=docker.io/library/nginx:dkoshkin
$ kubectl run nginx-should-be-broken --image=docker.io/library/nginx:dne
$ kubectl get pods 
NAME                                                              READY   STATUS              RESTARTS   AGE
cluster-autoscaler-0196931c-cb53-7abf-aa89-49c82c42ced5-86w5j8c   0/1     ContainerCreating   0          19m
nginx-should-be-broken                                            0/1     ErrImagePull        0          11m
nginx-working                                                     1/1     Running             0          11m

Which issue(s) this PR fixes:
Fixes #

How Has This Been Tested?:

Special notes for your reviewer:

@dkoshkin dkoshkin force-pushed the dkoshkin/feat-registry-mirror-addon-as-mirror branch from a16bb7f to 3f763d1 Compare May 2, 2025 22:53
Copy link
Contributor

github-actions bot commented May 6, 2025

This PR/issue depends on:

@dkoshkin dkoshkin force-pushed the dkoshkin/feat-registry-mirror-addon branch from 683a3e3 to 6e6c70b Compare May 7, 2025 18:40
@dkoshkin dkoshkin force-pushed the dkoshkin/feat-registry-mirror-addon-as-mirror branch from 042b7da to ce91230 Compare May 7, 2025 18:42
@dkoshkin dkoshkin force-pushed the dkoshkin/feat-registry-mirror-addon branch 6 times, most recently from dd251db to 816ffaa Compare May 8, 2025 22:44
@dkoshkin dkoshkin force-pushed the dkoshkin/feat-registry-mirror-addon-as-mirror branch from ce91230 to 6a7dde3 Compare May 8, 2025 22:57
@dkoshkin dkoshkin force-pushed the dkoshkin/feat-registry-mirror-addon-as-mirror branch from 6a7dde3 to 71bc9ca Compare May 8, 2025 22:57
@dkoshkin dkoshkin requested a review from supershal May 8, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants