Skip to content

Conversation

@farfromrefug
Copy link

So as i mentionned here #2
with sub osm extract the valhalla build scripts seems to be looking for the wrong tiles.
I fixed in the way :

  • store the bbox of the poly for each package
  • compute vtiles using this

It is also much faster as building tiles list from tilemask seems pretty slow.
In this case it means the tilemask is actually not needed anymore.

There is also code cleanup of consequently unecessary code and a VACUUM cleanup

@mtehver
Copy link
Contributor

mtehver commented Jun 9, 2021

The original issue is now fixed. I am not sure we need any of the other changes, as bounding box itself can be calculated from tile mask and is thus redundant. Also, the original script is quite fast when used with pypy, which is the recommended Python implementation when processing offline packages.

@farfromrefug
Copy link
Author

@mtehver i ll test your new implementation and report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants