Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements popup blocker handling for the identity-kit-web package by adding fallback mechanisms when browser popup blockers prevent the authentication window from opening. The changes provide multiple fallback strategies (redirect, copy to clipboard, manual URL handling) to ensure users can always complete the authentication flow.
- Enhanced
IdentityKitWeb.connect()method to detect popup blocking and implement fallback strategies - Added new React hook
useIdentityKitWithFallbackswith automatic popup blocker handling and user notifications - Maintained backward compatibility while adding optional detailed result reporting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
IdentityKitWeb.ts |
Enhanced connect method with popup blocker detection and fallback handling (redirect, copy, manual) |
useIdentityKit.ts |
Added connectWithResult method and new useIdentityKitWithFallbacks hook with callback-based fallback handling |
README.md |
Updated documentation with popup blocker handling examples and new hook usage patterns |
nuwa-kit/typescript/packages/identity-kit-web/src/IdentityKitWeb.ts
Outdated
Show resolved
Hide resolved
nuwa-kit/typescript/packages/identity-kit-web/src/react/useIdentityKit.ts
Outdated
Show resolved
Hide resolved
nuwa-kit/typescript/packages/identity-kit-web/src/react/useIdentityKit.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Deploying nuwa-login-demo with
|
| Latest commit: |
35deee1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf686028.nuwa-login-demo.pages.dev |
| Branch Preview URL: | https://handle-window-pop.nuwa-login-demo.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #224