Add validation support for pagination resolver mode (#2290)

* Update PaginateDirective.php * Cleanup * Adding a test * Update tests/Unit/Pagination/PaginateDirectiveTest.php Co-authored-by: Benedikt Franke <[email protected]> * Adding a test --------- Co-authored-by: Benedikt Franke <[email protected]>
nuwave · Feb 7, 2023 · 8756e1e · 8756e1e
1 parent 786ac58
commit 8756e1e
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ You can find and compare releases at the [GitHub release page](https://github.co
 
 ### Changed
 
+- Add validation support to `Paginator` with `resolver` mode
 - Pass resolver arguments to `FieldBuilderDirective::handleFieldBuilder()` https://github.com/nuwave/lighthouse/pull/2234
 - Expected resolver arguments in `ResolveInfo::enhanceBuilder()`
 - Pass the path array to `CacheKeyAndTags::key()` https://github.com/nuwave/lighthouse/pull/2176

diff --git a/src/Pagination/PaginateDirective.php b/src/Pagination/PaginateDirective.php
@@ -128,6 +128,9 @@ public function resolveField(FieldValue $fieldValue): FieldValue
     {
         $fieldValue->setResolver(function ($root, array $args, GraphQLContext $context, ResolveInfo $resolveInfo): Paginator {
             if ($this->directiveHasArgument('resolver')) {
+                // This is done only for validation
+                PaginationArgs::extractArgs($args, $this->paginationType(), $this->paginateMaxCount());
+
                 $paginator = $this->getResolverFromArgument('resolver')($root, $args, $context, $resolveInfo);
 
                 assert(

diff --git a/tests/Unit/Pagination/PaginateDirectiveTest.php b/tests/Unit/Pagination/PaginateDirectiveTest.php
@@ -487,6 +487,38 @@ public function testIsLimitedByMaxCountFromDirective(): void
         );
     }
 
+    public function testIsLimitedByMaxCountFromDirectiveWithResolver(): void
+    {
+        config(['lighthouse.pagination.max_count' => 5]);
+
+        $this->schema = /** @lang GraphQL */ '
+        type User {
+            id: ID!
+            name: String!
+        }
+
+        type Query {
+            users: [User!]! @paginate(maxCount: 6, resolver: "' . $this->qualifyTestResolver('returnPaginatedDataInsteadOfBuilder') . '")
+        }
+        ';
+
+        $result = $this->graphQL(/** @lang GraphQL */ '
+        {
+            users(first: 10) {
+                data {
+                    id
+                    name
+                }
+            }
+        }
+        ');
+
+        $this->assertSame(
+            PaginationArgs::requestedTooManyItems(6, 10),
+            $result->json('errors.0.message')
+        );
+    }
+
     public function testIsLimitedToMaxCountFromConfig(): void
     {
         config(['lighthouse.pagination.max_count' => 5]);