Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rehydration of subscription args with differing internal representations #1415

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Schema/AST/ASTBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ protected function applyArgManipulators(): void
}
}
}
}
}

/** Apply directives on input fields that can manipulate the AST. */
protected function applyInputFieldManipulators(): void
{
Expand Down
9 changes: 9 additions & 0 deletions src/Schema/Types/LaravelEnumType.php
Original file line number Diff line number Diff line change
Expand Up @@ -151,4 +151,13 @@ public function serialize($value): string

return $key;
}

public function parseValue($value)
{
if ($value instanceof $this->enumClass) {
return $value;
}

return parent::parseValue($value);
}
Comment on lines +155 to +162
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stayallive, I think this might fix the issue at least for enums from bensampo/laravel-enum. I don't know what we can do about the enums modified by @enum tnough.

}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 8 additions & 7 deletions src/Tracing/FederatedTracing/Proto/ContextualizedStats.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions src/Tracing/FederatedTracing/Proto/FieldStat.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/Tracing/FederatedTracing/Proto/PathErrorStats.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 9 additions & 8 deletions src/Tracing/FederatedTracing/Proto/QueryLatencyStats.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions src/Tracing/FederatedTracing/Proto/Report.php

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading