Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor builder types #2389

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use fqcn
thekonz committed May 3, 2023
commit 6020bfb615ea510876fb164820b49f9c0e7f6a41
2 changes: 1 addition & 1 deletion src/Pagination/PaginationArgs.php
Original file line number Diff line number Diff line change
@@ -73,7 +73,7 @@ protected static function calculateCurrentPage(int $first, int $after, int $defa
/**
* Apply the args to a builder, constructing a paginator.
*
* @return Paginator<Model>
* @return \Illuminate\Contracts\Pagination\Paginator<\Illuminate\Database\Eloquent\Model>
*/
public function applyToBuilder(Builder|ScoutBuilder $builder): Paginator
{
4 changes: 2 additions & 2 deletions src/Support/Contracts/ArgBuilderDirective.php
Original file line number Diff line number Diff line change
@@ -11,10 +11,10 @@ interface ArgBuilderDirective extends Directive
*
* TODO try adding a generic type parameter for the type of model when PHPStan handles it better
*
* @param Builder $builder the builder used to resolve the field
* @param \Illuminate\Contracts\Database\Query\Builder $builder the builder used to resolve the field
* @param mixed $value the client given value of the argument
*
* @return Builder the modified builder
* @return \Illuminate\Contracts\Database\Query\Builder the modified builder
*/
public function handleBuilder(Builder $builder, mixed $value): Builder;
}