refactor: shared command descriptions and --cwd default - #592
Merged
danielroe merged 5 commits intoDec 11, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
======================================
Coverage ? 1.31%
======================================
Files ? 44
Lines ? 2882
Branches ? 44
======================================
Hits ? 38
Misses ? 2803
Partials ? 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I split up |
danielroe
reviewed
Dec 9, 2024
danielroe
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
rootDirarg #450❓ Type of change
📚 Description
Is this a refactor and/or docs change 🤷
I found the
ROOTDIRandcwddefault value or fallback value a bit confusing, these changes should be functionally the same but instead handles the fallback to the shared argument configuration. Please make sure to check I'm not misunderstanding the fallback logic 😬I'm slowly working on syncing the descriptions between the command usage
-houtput and those described ondocs/api/commandspages, more PRs to come.