Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new provider filerobot #1680

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nicolaspayot
Copy link

πŸ”— Linked issue

Resolves #1380

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds a new provider (Filerobot from Scaleflex) to the list.

@nicolaspayot nicolaspayot force-pushed the feat/provider-filerobot branch from 2e6714c to 3645f77 Compare January 16, 2025 16:17
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 2.27273% with 43 lines in your changes missing coverage. Please review.

Project coverage is 63.57%. Comparing base (2366f74) to head (a65238d).

Files with missing lines Patch % Lines
src/runtime/providers/filerobot.ts 0.00% 41 Missing and 1 partial ⚠️
docs/pages/index.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   64.28%   63.57%   -0.72%     
==========================================
  Files          79       80       +1     
  Lines        3699     3742      +43     
  Branches      426      427       +1     
==========================================
+ Hits         2378     2379       +1     
- Misses       1296     1337      +41     
- Partials       25       26       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we likely need an image for the provider, in docs/public/providers/filerobot.svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New provider for Filerobot from Scaleflex
3 participants