fix(nuxi): migrate eve client to 0.31 session api - #2377
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
📝 WalkthroughWalkthroughThe Eve dependency updates from
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
benjamincanac
force-pushed
the
fix/eve-0.31-session-api
branch
from
August 10, 2026 15:58
594033f to
331b296
Compare
HugoRCD
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eve 0.31 replaced continuation-token session APIs with fixed, ID-addressed handles, so the bump and the migration have to land together. Pulling it out of #2366 leaves that PR with only the unrelated
check-provenancefailure. Same upgrade as HugoRCD/evlog#553.Client —
sendis positional, soagent.send({ message: X })becomesagent.send(X).initialSessionnow means attach to this session, so it's only set once a cursor exists; a fresh chat leaves it undefined and lets eve create the session, whichcreateChatSyncHandleralready persists. Renaming the old key tosessionIdcompiles but would attach every new chat to a session that doesn't exist yet (409session_not_active). Existing chats are unaffected:syncChatToDbonly ever persists a cursor whensessionIdis set, and the sync route validates it, so no continuation-token-only row exists.Agent —
ScheduleHandlerArgsis{ to, waitUntil, appAuth }andRouteHandlerArgshas noreceive, soreceive(slack, ...)becameto(slack, { channelId }).send(message, { auth })acrosslib/workflows.ts, both digest schedules andchannels/ops.ts.receiveOnSlackis nowsendToSlack, and the workflow template inlayers/nuxi/README.mdis updated to match. Without this the weekly digest, firehose summary and their ops triggers throw on first fire.Also drops
chatIdfromUseEveChatOptions, which nothing reads sinceinitialSessionstopped using it.Worth knowing — nothing under
layers/*/agent/**is in any tsconfig, andeve buildbundles without typechecking (I putargs.receiveback and it still exited 0 and produced a deployable bundle). So the agent half of this diff has no automated verification, and the schedules only run on cron. Verified against the shipped 0.31.3 type declarations instead.hooks/rate-limit.tsandhooks/chat-title.tsstill readctx.channel.continuationToken, which still exists in 0.31.3, so they're untouched. If that value stops matching the chat id both hooks early-return and titles quietly stop generating.pnpm typecheck,pnpm lint, vitest 59/59 andeve buildpass. Not exercised against a running eve: worth starting a fresh chat, reloading it, and firing one ops trigger before merging.