fix(Link): proxy download property
#3879
Conversation
commit: |
src/runtime/components/Link.vue
Outdated
| * If set to a string, it suggests that string as the filename. | ||
| * If set to `true` or an empty string, the browser suggests a filename. | ||
| */ | ||
| download?: string | boolean |
There was a problem hiding this comment.
I think we can remove this prop here as it does not belong to NuxtLink. Also, the pickLinkProps is not used in the Button or Link component directly but when using items to render DropdownMenu, NavigationMenu, etc.
There was a problem hiding this comment.
Updated, I hope I got it right
There was a problem hiding this comment.
No I meant you can remove it completely 😊 Adding it to the pickLinkProps is enough
There was a problem hiding this comment.
Oh, I see now. Thank you for review!
There was a problem hiding this comment.
Just to emphasize, the <UButton href="/image.png" download="custom-filename.png"> was already working. This will only allow to use to download property inside DropdownMenu items for example.
benjamincanac
changed the title
downloaddownload property
🔗 Linked issue
No specific issue linked
❓ Type of change
📚 Description
This change updates the
pickLinkPropsutility function to include thedownloadproperty in the list of props it picks from the input.Previously, the
Linkcomponent (and other components using this utility) would not pass the standard HTMLdownloadattribute through to the underlying<a>tag. This prevented users from creating links that trigger a file download directly via the component.By adding
downloadto thepropsToIncludearray, this attribute is now correctly proxied, allowing users to specify download behavior like<ULink href="/path/to/file.zip" download>or<UButton href="/image.png" download="custom-filename.png">.📝 Checklist