-
Notifications
You must be signed in to change notification settings - Fork 741
feat(Table): column resizing #4110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
β¦ek/ui into feat/stepper-icon-class
Maybe I'm being too specific with this? The use can see it in detail in the props section.
@benjamincanac Could you give me some guidelines on how the resize handle should be implemented? I have found this image but then I checked the pro docs and found that the DashboardPanel uses a resize handle without the primary color, not sure which one I should follow. |
Some notes:
|
β¦-column-resize
@J-Michalek Your PR seems to have lots of left-overs from other PRs, would you mind cleaning it up? It would facilitate the review π |
Yes, I realized something was wrong the second I requested review... I will let you know when it is ready, sorry for disturbing you. Edit: Resolved the issue rather quickly, should be ready for review. |
β¦lek/ui into feat/table-column-resize
commit: |
Ready for review/testing. |
/** | ||
* Whether the table should fit its container's width or expand it when resizing the columns. | ||
* | ||
* @defaultValue 'fit' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-Michalek This is a lie, current default is 'expand'.
π Linked issue
Resolves: #3761
Helps with: #2441
β Type of change
π Description
I have added a
enableColumnResizing
prop to enable column resizing for the Table component. Added the resize handle element to the header which is rendered when the column is resizable.Users want an option to make the table columns resizable. The goal is to implement all TanStack Table features and this is one of them.
π Checklist