Skip to content

feat(Table): column resizing #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 53 commits into
base: v3
Choose a base branch
from

Conversation

J-Michalek
Copy link
Contributor

@J-Michalek J-Michalek commented May 9, 2025

πŸ”— Linked issue

Resolves: #3761
Helps with: #2441

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I have added a enableColumnResizing prop to enable column resizing for the Table component. Added the resize handle element to the header which is rendered when the column is resizable.

Users want an option to make the table columns resizable. The goal is to implement all TanStack Table features and this is one of them.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

J-Michalek and others added 30 commits May 4, 2025 07:59
Maybe I'm being too specific with this? The use can see it in detail in the props section.
@J-Michalek
Copy link
Contributor Author

@benjamincanac Could you give me some guidelines on how the resize handle should be implemented? I have found this image but then I checked the pro docs and found that the DashboardPanel uses a resize handle without the primary color, not sure which one I should follow.

@J-Michalek
Copy link
Contributor Author

J-Michalek commented May 9, 2025

Some notes:

@J-Michalek J-Michalek marked this pull request as ready for review May 14, 2025 08:50
@benjamincanac
Copy link
Member

@J-Michalek Your PR seems to have lots of left-overs from other PRs, would you mind cleaning it up? It would facilitate the review 😊

@benjamincanac benjamincanac changed the title feat(table): column resizing feat(Table): column resizing May 14, 2025
@J-Michalek
Copy link
Contributor Author

J-Michalek commented May 14, 2025

@J-Michalek Your PR seems to have lots of left-overs from other PRs, would you mind cleaning it up? It would facilitate the review 😊

Yes, I realized something was wrong the second I requested review... I will let you know when it is ready, sorry for disturbing you.

Edit: Resolved the issue rather quickly, should be ready for review.

Copy link

pkg-pr-new bot commented May 14, 2025

npm i https://pkg.pr.new/@nuxt/ui@4110

commit: d0963f6

@J-Michalek
Copy link
Contributor Author

Ready for review/testing.

/**
* Whether the table should fit its container's width or expand it when resizing the columns.
*
* @defaultValue 'fit'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J-Michalek This is a lie, current default is 'expand'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table resize feature
2 participants