Skip to content

fix(Form): conditionally type form data via transform prop #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

tankosinn
Copy link

@tankosinn tankosinn commented May 19, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Introduce the FormData<S, T> conditional type helper.
  • Update the onSubmit prop and submit event payload to use FormData<S, T>.
  • Add a T generic to the internal _validate function and to Form.validate() to respect the transform option when inferring the form schema.
  • Use the S (FormSchema) generic for Form instead of I (InferInput<S>) enabling schema inference via FormData<S, T>.
  • No runtime behavior changes; all changes are type-only.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented May 19, 2025

npm i https://pkg.pr.new/@nuxt/ui@4188

commit: f25ca8b

Copy link
Member

@romhml romhml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tankosinn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants