Skip to content

feat(FieldGroup)!: rename from ButtonGroup #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 12, 2025
Merged

feat(FieldGroup)!: rename from ButtonGroup #4596

merged 9 commits into from
Aug 12, 2025

Conversation

J-Michalek
Copy link
Contributor

@J-Michalek J-Michalek commented Jul 25, 2025 •
edited
Loading

🔗 Linked issue

Resolves: #4544

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The ButtonGroup can and is being used with more things than just buttons which made the naming a little misleading, newly it is called FieldGroup which is more general.

Functionality remains the same.

Migration guide:

  • rename UButtonGroup to UFieldGroup
  • rename theme variant from buttonGroup to fieldGroup

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@J-Michalek
Copy link
Contributor Author

I've removed the old button-group page from the docs, but perhaps it should remain there for some time after v4 and guide the users to the new page for field-group.

@benjamincanac benjamincanac added the v4 #4488 label Jul 27, 2025
@benjamincanac Volta.net
Copy link
Member

@J-Michalek We can simply add a redirect: https://github.com/nuxt/ui/blob/v3/docs/nuxt.config.ts#L108

@benjamincanac benjamincanac changed the title refactor(ButtonGroup): rename to FieldGroup refactor(ButtonGroup)!: rename to FieldGroup Aug 6, 2025
@J-Michalek
fix(FileUpload): accept any subtype
5b75835 
The accept prop did not work with image/* etc.
@J-Michalek
Revert "fix(FileUpload): accept any subtype"
dffdeaf 
This reverts commit 5b75835.
@J-Michalek
Copy link
Contributor Author

I've added the redirect from /components/button-group to /components/field-group.

@benjamincanac benjamincanac force-pushed the v4 branch 2 times, most recently from 53d43ad to de4c8a9 Compare August 11, 2025 16:14
@benjamincanac
Copy link
Member

@J-Michalek Sorry I should have merged your PR first, the last changes on v4 have moved things around. Let me know if you want me to handle the conflicts!

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 12, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4596

commit: e5f06ab

@J-Michalek
Copy link
Contributor Author

@benjamincanac No worries, I've resolved the conflicts.

benjamincanac
benjamincanac reviewed Aug 12, 2025
View reviewed changes
@benjamincanac benjamincanac changed the title refactor(ButtonGroup)!: rename to FieldGroup feat(ButtonGroup)!: rename to FieldGroup Aug 12, 2025
@benjamincanac benjamincanac merged commit 0ffb146 into nuxt:v4 Aug 12, 2025
5 of 6 checks passed
@benjamincanac
Copy link
Member

Thanks @J-Michalek! 😊

benjamincanac added a commit that referenced this pull request Aug 13, 2025
@J-Michalek @benjamincanac
feat(ButtonGroup)!: rename to FieldGroup (#4596)
6036a74 
Co-authored-by: Jakub <[email protected]>
Co-authored-by: Benjamin Canac <[email protected]>
benjamincanac added a commit that referenced this pull request Aug 13, 2025
@J-Michalek @benjamincanac
feat(ButtonGroup)!: rename to FieldGroup (#4596)
d31d57b 
Co-authored-by: Jakub <[email protected]>
Co-authored-by: Benjamin Canac <[email protected]>
@benjamincanac benjamincanac mentioned this pull request Aug 12, 2025
Closed
34 tasks
benjamincanac added a commit that referenced this pull request Aug 14, 2025
@J-Michalek @benjamincanac
feat(ButtonGroup)!: rename to FieldGroup (#4596)
3799982 
Co-authored-by: Jakub <[email protected]>
Co-authored-by: Benjamin Canac <[email protected]>
@benjamincanac benjamincanac changed the title feat(ButtonGroup)!: rename to FieldGroup feat(FieldGroup)!: rename from ButtonGroup Aug 14, 2025
benjamincanac added a commit that referenced this pull request Aug 14, 2025
@J-Michalek @benjamincanac
feat(FieldGroup)!: rename from ButtonGroup (#4596)
03bb16f 
Co-authored-by: Jakub <[email protected]>
Co-authored-by: Benjamin Canac <[email protected]>
benjamincanac added a commit that referenced this pull request Aug 14, 2025
@J-Michalek @benjamincanac
feat(FieldGroup)!: rename from ButtonGroup (#4596)
8aa96d1 
Co-authored-by: Jakub <[email protected]>
Co-authored-by: Benjamin Canac <[email protected]>
benjamincanac added a commit that referenced this pull request Aug 25, 2025
@J-Michalek @benjamincanac
feat(FieldGroup)!: rename from ButtonGroup (#4596)
c3c3443 
Co-authored-by: Jakub <[email protected]>
Co-authored-by: Benjamin Canac <[email protected]>
benjamincanac added a commit that referenced this pull request Aug 25, 2025
@J-Michalek @benjamincanac
feat(FieldGroup)!: rename from ButtonGroup (#4596)
c2c1c26 
Co-authored-by: Jakub <[email protected]>
Co-authored-by: Benjamin Canac <[email protected]>
benjamincanac added a commit that referenced this pull request Sep 1, 2025
@J-Michalek @benjamincanac
feat(FieldGroup)!: rename from ButtonGroup (#4596)
a0963eb 
Co-authored-by: Jakub <[email protected]>
Co-authored-by: Benjamin Canac <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
v4 #4488
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J-Michalek @benjamincanac