Skip to content

fix(InputMenu): stop adding new chip in ui in case not create mode #6776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
al1maher wants to merge 1 commit into
base: v4
Choose a base branch
from
+12 −0
Open

fix(InputMenu): stop adding new chip in ui in case not create mode #6776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/runtime/components/InputMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,17 @@ function onClear() {
emits('clear')
}

function onTagInputKeydown(e: KeyboardEvent) {
if (e.key !== 'Enter') return

// reka-ui's TagsInputRoot adds the raw search text as a tag on Enter regardless of
// whether it matches a real item or createItem is enabled. Block that so
// we never render a chip that isn't reflected in modelValue.
if (!props.createItem) {
e.preventDefault()
}
}
Comment on lines +551 to +560

@benjamincanac benjamincanac Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @al1maher! I don't think createItem is the right check though, the chip is still there with createItem: true and the menu closed. And preventing every Enter breaks form submission inside a UForm.

I think I would use searchTerm instead:

Suggested change
function onTagInputKeydown(e: KeyboardEvent) {
if (e.key !== 'Enter') return
// reka-ui's TagsInputRoot adds the raw search text as a tag on Enter regardless of
// whether it matches a real item or createItem is enabled. Block that so
// we never render a chip that isn't reflected in modelValue.
if (!props.createItem) {
e.preventDefault()
}
}
function onTagsInputKeydown(event: KeyboardEvent) {
if (event.isComposing || !searchTerm.value) {
return
}
event.preventDefault()
}

What do you think?

@al1maher al1maher Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your approach is more correct, I made it that way as I was focusing on not breaking the create functionality but I think your solution is more robust


const viewportRef = useTemplateRef('viewportRef')

const comboboxRootRef = useTemplateRef('comboboxRootRef')
Expand Down Expand Up @@ -694,6 +705,7 @@ defineExpose({
data-slot="tagsInput"
:class="ui.tagsInput({ class: props.ui?.tagsInput })"
@change.stop
@keydown.enter="onTagInputKeydown"
/>
</Component.Input>
</TagsInputRoot>
Expand Down
Loading