Repository navigation
feat(profiles): add biographies and responsive hero layout - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds linked biographies beneath each profile’s greeting, with English, French, and Persian copy. On mobile and tablets, Spencer’s first sentence stays visible and an inline “Read more...” reveals the affiliations; Sara’s single-sentence biography remains visible.
The hero uses two columns from 600px, with a compact portrait beside the text. Greetings scale continuously across breakpoints, with sizing adjusted for the longer French greeting. Responsive image sizes match the updated layout.
Validation:
pnpm check— formatting, lint, typecheck, 123 tests, and Vite build passed.HOMEPAGE_SITE=spencer pnpm build— passed.HOMEPAGE_SITE=sara pnpm build— passed.