Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: operating system icons #362

Merged
merged 10 commits into from
Dec 30, 2023
Merged

Conversation

miversen33
Copy link
Contributor

#361

There are a few things to call out here.

  • This adds a completely new table to the return of icons-default and icons-light called icons_by_operating_system. This set of icons is added with the other icons to the lookup table that is generated during initialization of all devicons.
  • This (currently) does not pass the provided make tests due to the addition of the new icons_by_operating_system attribute
  • There are several icons that I am choosing to omit from this. The following list of icons were omitted as the provided icon by nerdfonts cheat-sheet was not found when I pasted it into my terminal. I am currently using the patched version of firacode so I suspect these various items are all in a newer patch for Firacode. In any case, I did not see them and thus did not want to commit them. I did complete them however so a lua file is attached to this message with each one so that it can be reviewed should someone decide to include these icons
    • archcraft
    • arcolinux
    • arduino
    • biglinux
    • crystal
    • garuda
    • hyperbola
    • kde_neon
    • kubuntu
    • locos
    • lxle
    • mate
    • mxlinux
    • parabola
    • puppy
    • qubesos
    • tails
    • trisquel
    • vanilla
    • xerolinux

Pretty much all colors were established via "best guess"/"eyeball test". Others have figured out Apple/Windows color palettes and thus for these 2 I pulled the primary color from their established color palette. Feel free to adjust the color codes as needed. Color can be subjective after all :)

On colors, I did not do anything fancy for any of the OS icons for the
"light" vs "default". It is a literal copy and paste between the 2. If someone wants different colors for the OS when requesting a "light" version of them, they can do that work lol.

I know that this PR doesn't exactly follow the Contributing guidelines request but given that is a bit chunky and adding stuff that doesn't really have a home, I figured it would be worth explaining that. Do let me know what you believe needs to be changed/fixed/etc to get this in :)

potential-icons.zip

@alex-courtis
Copy link
Member

This looks great. The operating system distinction is not exposed to the user.

I'm not sure about removing linux from the names. The font names all have linux in them and it will be useful to disabmiguate.

@gegoune ? @Akmadan23 ?

@miversen33
Copy link
Contributor Author

This looks great. The operating system distinction is not exposed to the user.

I'm not sure about removing linux from the names. The font names all have linux in them and it will be useful to disabmiguate.

@gegoune ? @Akmadan23 ?

The initial commit had certain distros that had names like almalinux or rocky linux while others (such as redhat) did not. The removal of "linux" from the names was a way to make the names more consistent across the board. IMO they should either all have linux in their name, or none of them should in order to prevent confusion and make it easier on people using the icons in scripts/plugins

@Akmadan23
Copy link
Collaborator

This looks great. The operating system distinction is not exposed to the user.

I'm not sure about removing linux from the names. The font names all have linux in them and it will be useful to disabmiguate.

@gegoune ? @Akmadan23 ?

Looks good. As @miversen33 said, either all or none should have linux in the name, and I'd go with none, since all of them are linux distros (except of course windows, macos and the BSDs, which are pretty obvious).

We should also update the color generation script to handle the icons_by_operating_system section now...

@miversen33
Copy link
Contributor Author

I attempted to add the icons_by_operating_system and while it "looked good", it seems to break the icons_by_file_type table in icons-light during the generation. Thus I am going to have to let someone else do that

@Akmadan23
Copy link
Collaborator

It should be ok now. Could you please run it via make colors and push the updates?

@miversen33
Copy link
Contributor Author

Done :)

@Akmadan23
Copy link
Collaborator

Awesome!

@alex-courtis alex-courtis changed the title DRAFT: Add Operating System Icons feat: add operating system icons Dec 30, 2023
@alex-courtis alex-courtis changed the title feat: add operating system icons feat: operating system icons Dec 30, 2023
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution!

@alex-courtis alex-courtis merged commit 22e62c7 into nvim-tree:master Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants