-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: operating system icons #362
Conversation
This looks great. The operating system distinction is not exposed to the user. I'm not sure about removing linux from the names. The font names all have linux in them and it will be useful to disabmiguate. @gegoune ? @Akmadan23 ? |
The initial commit had certain distros that had names like |
Looks good. As @miversen33 said, either all or none should have linux in the name, and I'd go with none, since all of them are linux distros (except of course windows, macos and the BSDs, which are pretty obvious). We should also update the color generation script to handle the |
This reverts commit d1cc9f3.
I attempted to add the |
It should be ok now. Could you please run it via |
Done :) |
Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your contribution!
#361
There are a few things to call out here.
icons-default
andicons-light
calledicons_by_operating_system
. This set of icons is added with the other icons to the lookup table that is generated during initialization of all devicons.icons_by_operating_system
attributePretty much all colors were established via "best guess"/"eyeball test". Others have figured out Apple/Windows color palettes and thus for these 2 I pulled the primary color from their established color palette. Feel free to adjust the color codes as needed. Color can be subjective after all :)
On colors, I did not do anything fancy for any of the OS icons for the
"light" vs "default". It is a literal copy and paste between the 2. If someone wants different colors for the OS when requesting a "light" version of them, they can do that work lol.
I know that this PR doesn't exactly follow the Contributing guidelines request but given that is a bit chunky and adding stuff that doesn't really have a home, I figured it would be worth explaining that. Do let me know what you believe needs to be changed/fixed/etc to get this in :)
potential-icons.zip