-
Notifications
You must be signed in to change notification settings - Fork 1
add sqlite_lib and other improvements #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+20,541
−19,423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of raw jsonb
remove default_checks
Update branch to track main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant updates across the workspace, most notably the addition of a new procedural macro crate, workspace dependency consolidation, and improvements to documentation practices. It also updates package editions for consistency, makes minor CLI fixes, and cleans up workflow steps.
Workspace and Dependency Management:
test_utilanddfraw_parser_proc_macrosinCargo.toml, and centralized most dependencies using[workspace.dependencies]for easier management and version consistency across crates.cli/Cargo.toml,jsonlib/Cargo.toml) to use workspace dependencies, reducing duplication and ensuring alignment of dependency versions. [1] [2]Procedural Macro Infrastructure:
dfraw_parser_proc_macroswith its own manifest and source files, providing custom derive macros forCleanableandIsEmptytraits. These macros automate boilerplate for cleaning and emptiness checks on structs, supporting custom attributes for fine-tuned control. [1] [2] [3] [4]Documentation Improvements:
DOCUMENTATION_REFERENCE.md, a comprehensive quick-reference guide for documenting the codebase. It covers common patterns, section keywords, linking, and best practices tailored for the Dwarf Fortress context.Build and Workflow Cleanups:
clippy.ymlGitHub Actions workflow, streamlining CI checks.Minor Fixes and Updates:
cliandjsonlibcrates to 2024 for consistency. [1] [2]RawModuleLocation::ModstoRawModuleLocation::WorkshopModsfor the--modsflag, and improved a log message for clarity. [1] [2]These changes collectively improve code maintainability, documentation quality, and developer experience across the project.