Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jason default points change #706

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Jason default points change #706

merged 3 commits into from
Mar 6, 2025
+25 −24

Conversation

jkuo630
Copy link
Contributor

@jkuo630 jkuo630 commented Mar 4, 2025

image

  • set default points to 15 on frontend and backend
  • also made a safeguard such that if points fall to 0, it shouldn't reset back to default; it should stay at 0

@jkuo630 jkuo630 requested review from DonaldKLee and joannelex March 4, 2025 12:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit f999a03):

https://nwplus-ubc--pr706-jason-default-points-1az4uvj9.web.app

(expires Thu, 13 Mar 2025 02:36:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48

@DonaldKLee
Copy link
Member

Might handle this via QR app instead, otherwise they'd need to view the rewards page to get their points, mb if the ticket wasn't clear

i can make a pr for this rn

@jkuo630
Copy link
Contributor Author

jkuo630 commented Mar 6, 2025

o shi okok mbmb

@jkuo630 jkuo630 closed this Mar 6, 2025
@DonaldKLee
Copy link
Member

wait nvm im dumb, this is good LOL, cause we don't have a field to keep track of points 😂

@DonaldKLee DonaldKLee reopened this Mar 6, 2025
@DonaldKLee
Copy link
Member

gonna push a commit then merge!

@jkuo630
Copy link
Contributor Author

jkuo630 commented Mar 6, 2025

LOL okok sound goood thanks!!

@DonaldKLee DonaldKLee merged commit d0bbd69 into dev Mar 6, 2025
2 checks passed
@DonaldKLee DonaldKLee deleted the jason-default-points-change branch March 6, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonaldKLee DonaldKLee

@joannelex joannelex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkuo630 @DonaldKLee @jasonkuoubc