fix crash in scramble script by adding try/except guard on node saving #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
==========================================
- Coverage 94.88% 94.88% -0.01%
==========================================
Files 89 91 +2
Lines 3816 3892 +76
==========================================
+ Hits 3621 3693 +72
- Misses 195 199 +4 ☔ View full report in Codecov by Sentry. |
Comment on lines
39
to
41
| # This transaction is not atomic so that even if there's some error with | ||
| # the scrambled data, we can scramble it partially. I'd rather break someone's | ||
| # dev env than give someone PII accidentally |
There was a problem hiding this comment.
Doesn't removing the atomic block make it more likely that we will disclose PII? Since a single row could fail silently?
There was a problem hiding this comment.
whoops, I forgot to push again. I have another commit that sets up atomic for each individual transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title. Ran into this while getting a new dev online